> Can I please get a review of this change which removes support for the > `-noclassgc`, `-noverify`, `-verifyremote` options from the `java` launcher > and the `-Xverify:none` option from the VM? > > These options have been deprecated since some releases and have been printing > a deprecation warning. There were a few more `java` launcher options which > were deprecated for removal a while back through > https://bugs.openjdk.org/browse/JDK-8340244. Those remaining ones will > continue to stay deprecated but will be removed in some future version, given > that they are relatively more commonly used. > > The CSR for this change is available for review > https://bugs.openjdk.org/browse/JDK-8382727 and has additional details about > this change. > > The `test/hotspot/jtreg/gc/shenandoah/compiler/CallMultipleCatchProjs.java` > test had to be updated to remove its usage of `-Xverify:none`. That test was > introduced in https://bugs.openjdk.org/browse/JDK-8231405, but I haven't been > able to locate a RFR thread for that (I checked hotspot-gc-dev, > shenandoah-dev mailing lists from September 2019), so it's not clear to me > why the `-Xverify:none` was needed in that test. A brief look at that test > suggests that this option may not be necessary, so I've removed it. Please > take a look and let me know if that option was intentional (in which case we > need to decide how we deal with that test with this option being removed). > > tier1, tier2, tier3 testing has completed without any related failures with > this change. I plan to run higher tier tests in the coming days. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai).
Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - merge latest from master branch - merge latest from master branch - remove mention of -Xverify:none from the java launcher help text - remove -Xverify:none from a test - 8373481: Remove the deprecated -noclassgc, -noverify, -Xverify:none and -verifyremote options from the java launcher ------------- Changes: - all: https://git.openjdk.org/jdk/pull/30877/files - new: https://git.openjdk.org/jdk/pull/30877/files/d648ace9..d9bfc59d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=30877&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=30877&range=01-02 Stats: 59325 lines in 499 files changed: 4811 ins; 53262 del; 1252 mod Patch: https://git.openjdk.org/jdk/pull/30877.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/30877/head:pull/30877 PR: https://git.openjdk.org/jdk/pull/30877
