On Mon, 23 Mar 2026 10:19:42 GMT, Martin Doerr <[email protected]> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update >> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64Frame.java >> >> Co-authored-by: Chris Plummer <[email protected]> >> - Update >> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64Frame.java >> >> Co-authored-by: Chris Plummer <[email protected]> > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/aarch64/AARCH64ContinuationEntry.java > line 40: > >> 38: @Override >> 39: public Frame toFrame() { >> 40: return new AARCH64Frame(getEntrySP(), getEntrySP(), >> getEntryFP(), getEntryPC()); > > Do we need the same code replicated for all platforms? (May make senes. Not > sure.) This structure comes from HotSpot. `to_frame()` is defined in `continuationEntry_<arch>.inline.hpp`. So I think it is better to follow it because most of source file in SA follows HotSpot manner. > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/ppc64/PPC64Frame.java > line 379: > >> 377: // It is same with c'tor arguments of RegisterMap in >> frame::next_frame(). >> 378: // >> 379: // HotSpot code in cpu/riscv/frame_riscv.inline.hpp: > > Should better refer to cpu/ppc/frame_ppc.inline.hpp Thanks! Fixed it in new commit. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30107#discussion_r2975157645 PR Review Comment: https://git.openjdk.org/jdk/pull/30107#discussion_r2975159159
