On Wed, 4 Mar 2026 07:52:11 GMT, David Holmes <[email protected]> wrote:
>> Jean-Philippe Bempel has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fix whitespaces
>
> This seems to work:
>
> diff --git
> a/test/jdk/java/lang/instrument/RetransformRecordTypeAnn/TestRetransformRecord.java
>
> b/test/jdk/java/lang/instrument/RetransformRecordTypeAnn/TestRetransformRecord.java
> index 628eb460564..e8f1ba176d1 100644
> ---
> a/test/jdk/java/lang/instrument/RetransformRecordTypeAnn/TestRetransformRecord.java
> +++
> b/test/jdk/java/lang/instrument/RetransformRecordTypeAnn/TestRetransformRecord.java
> @@ -32,7 +32,8 @@
> * @modules java.compiler
> * java.instrument
> * @compile ../NamedBuffer.java
> - * @run driver RunAsmTools altered/MyRecord.jcod altered
> + * @compile altered/MyRecord.jcod
> + * @run driver jdk.test.lib.helpers.ClassFileInstaller MyRecord
> * @compile MyRecord.java
> * @run main RedefineClassHelper
> * @run main/othervm -javaagent:redefineagent.jar -Xlog:redefine*=debug
> TestRetransformRecord
> @@ -57,7 +58,7 @@ public class TestRetransformRecord {
>
> public static void main(String[] args) throws Exception {
> MyRecord.parse("foo");
> - File clsfile = new File(DEST + "/altered/MyRecord.class");
> + File clsfile = new File("MyRecord.class");
> byte[] buf = null;
> try (FileInputStream str = new FileInputStream(clsfile)) {
> buf = NamedBuffer.loadBufferFromStream(str);
>
> The ClassfileInstaller copies the class file from the test-classes directory
> to the `pwd` and so we can load it from there.
@dholmes-ora
> The ClassfileInstaller copies the class file from the test-classes directory
> to the `pwd` and so we can load it from there.
Thanks! it indeed works. I did not understood that this was different
directories.
@sspitsyn
> Also, I'm curious what testing was done to make sure there are no regressions
> introduced.
running tier1
-------------
PR Comment: https://git.openjdk.org/jdk/pull/29445#issuecomment-3999938375
