On Wed, 7 Jan 2026 12:48:29 GMT, Eunbin Son <[email protected]> wrote:
>> ### Summary
>> Fix incorrect regex usage in CoreUtils.getCoreFileLocation.
>>
>> ### Description
>> CoreUtils.getCoreFileLocation uses String.split("\s", 2).
>> The string literal "\s" represents a backspace character, not a whitespace
>> regex.
>> As a result, the split operation does not separate fields on whitespace.
>> This change replaces the pattern with `"\\s+"` to correctly split on
>> whitespace.
>> No other logic is modified.
>>
>> ### Bug ID : JDK-8374341
>> https://bugs.java.com/bugdatabase/view_bug?bug_id=8374341
>
> Eunbin Son has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to the previous content of the PR. The pull request contains one new
> commit since the last revision:
>
> JDK-8374341: Remove unverified systemd-coredump handling code
Looks good. The titles of this PR and the JBS Issue should be updated as
mentioned earlier.
Agreed, multiple issues and the fallback message it prints is the most useful
thing it does. Yes maybe we can come back here with improved handling...
-------------
Marked as reviewed by kevinw (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/28984#pullrequestreview-3662739622
PR Comment: https://git.openjdk.org/jdk/pull/28984#issuecomment-3751677986
