On Fri, 17 Oct 2025 10:05:39 GMT, Sean Coffey <[email protected]> wrote:
>> Simple tweak to jcmd Thread.print help message
>>
>> jdk_svc test group ran and green
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> man page and better help messages
src/hotspot/share/services/diagnosticCommand.hpp line 361:
> 359: return "Print all platform threads with stacktraces. "
> 360: "Use Thread.dump_to_file command for extended threads "
> 361: "detail including virtual thread information.";
Can you try "Print all platform threads, and mounted virtual threads, with
stack traces"?
Not sure about the second line. I assume you are proposing to add this in order
to created awareness but saying "extended threads detail" is confusing. If a
second line is added then it could be very simple, e.g. "The
Thread.dump_to_file command will print all threads to a file".
src/hotspot/share/services/diagnosticCommand.hpp line 773:
> 771: }
> 772: static const char *description() {
> 773: return "Dump threads (including virtual), with stack traces, "
If you change it to "Dump all threads" then it would be simpler.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27861#discussion_r2439162626
PR Review Comment: https://git.openjdk.org/jdk/pull/27861#discussion_r2439140850
