On Tue, 26 Aug 2025 09:38:54 GMT, Fredrik Bredberg <[email protected]> wrote:
>> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reviewer feedback > > A good looking PR, and a good step in the right direction. Nice! > > But as @kimbarrett I also noticed there are a number of calls with `buflen - > 1`, which in my case consumed too mush of the review time. So it would be > nice to see a follow up that deals with code like > [this](https://github.com/openjdk/jdk/blob/38003a227a55dbd6adb89dcb10dc619f08bb0187/src/hotspot/os/bsd/os_bsd.cpp#L2493). Thanks for the review @fbredber . I have added your cleanup suggestion to [JDK-8365896](https://bugs.openjdk.org/browse/JDK-8365896) as well. ------------- PR Comment: https://git.openjdk.org/jdk/pull/26849#issuecomment-3226972822
