On Mon, 30 Jun 2025 23:26:17 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Update test/lib/RedefineClassHelper.java >> >> Co-authored-by: David Holmes >> <62092539+dholmes-...@users.noreply.github.com> >> - Update test/lib/RedefineClassHelper.java >> >> Co-authored-by: David Holmes >> <62092539+dholmes-...@users.noreply.github.com> >> - Update test/lib/RedefineClassHelper.java >> >> Co-authored-by: David Holmes >> <62092539+dholmes-...@users.noreply.github.com> > > test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/ClassVersionAfterRedefine.java > line 45: > >> 43: ClassVersionAfterRedefine cvar = new ClassVersionAfterRedefine(); >> 44: >> 45: // Poor man's renaming of class "TestClassOld" to "TestClassXXX" > > It is not "poor man's" renaming anymore and > RedefineClassHelper.replaceClassName() is self-explanable. So this comment > could be just removed. Okay. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25857#discussion_r2176243389
