On Wed, 25 Jun 2025 17:48:02 GMT, Daniel D. Daugherty <dcu...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix the test > > src/hotspot/share/runtime/mutexLocker.cpp line 236: > >> 234: MUTEX_DEFN(Notification_lock , PaddedMonitor, service); >> // used for notification thread operations >> 235: >> 236: MUTEX_DEFN(JmethodIdCreation_lock , PaddedMutex , >> nosafepoint-1); // used for creating jmethodIDs locks HandshakeState_lock > > Perhaps: > > MUTEX_DEFN(JmethodIdCreation_lock , PaddedMutex , nosafepoint-1); > // used for creating jmethodIDs, can lock HandshakeState_lock which is at > nosafepoint ugh that makes the line too long for me. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25267#discussion_r2168911755
