On Mon, 23 Jun 2025 16:41:35 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> Chris Plummer has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> startLocalDebugee renamed to startDebugee
>
> test/hotspot/jtreg/vmTestbase/nsk/share/jpda/DebugeeProcess.java line 50:
>
>> 48: * @see nsk.share.jdwp.Debugee
>> 49: */
>> 50: public class DebugeeProcess {
>
> Are there any reason to make it non-abstract.. Even DebugeeProcess doesn't
> have abstract methods, only jid/jdwp subclasses might be used.Might be left
> it abstract?
Currently it is only used via subclasses, but that doesn't necessarily mean it
couldn't be used directly. Is there a reason you want to disallow that?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25887#discussion_r2162093947
