On Sun, 1 Jun 2025 15:24:17 GMT, Markus Grönlund <mgron...@openjdk.org> wrote:
>> Johannes Bechberger has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Refactoring
>> - Remove convoluted native trace logic
>
> src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp line 344:
>
>> 342:
>> 343: // equals operator for JfrSampleRequest
>> 344: inline bool operator==(const JfrSampleRequest& lhs, const
>> JfrSampleRequest& rhs) {
>
> Can be removed.
Unless you still want to try the ljf JfrSampleRequest optimization for the
native ljf, which I kind of like now that I understand it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2119386104
