On Sun, 1 Jun 2025 13:19:48 GMT, Markus Grönlund <mgron...@openjdk.org> wrote:
>> Johannes Bechberger has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Refactoring
>> - Remove convoluted native trace logic
>
> src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp line 558:
>
>> 556: jt->is_JfrRecorder_thread()) {
>> 557: queue.increment_lost_samples();
>> 558: tl->set_do_async_processing_of_cpu_time_jfr_requests(false);
>
> Why is this restored here?
Because I shouldn't sample if the thread isn't in native state anymore. The
thread is probably sampled anyway on the outgoing safepoint.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2119157906
