On Fri, 30 May 2025 09:19:47 GMT, Johannes Bechberger <jbechber...@openjdk.org> wrote:
>> src/hotspot/share/jfr/metadata/metadata.xml line 975: >> >>> 973: </Event> >>> 974: >>> 975: <Event name="CPUTimeSampleLoss" category="Java Virtual Machine, >>> Profiling" label="CPU Time Method Profiling Lost Samples" >>> description="Records that the CPU time sampler lost samples" >> >> I'm not a reviewer, but I just wanted to comment something I noticed. >> The JEP document says CPUTimeSampleLos'**t**', but the implementation says >> CPUTimeSampleLos'**s**'. Which one is correct? >> A sentence from the JEP document: >> >> Another new event, `jdk.CPUTimeSampleLost`, is emitted when samples are lost >> ... > > Thanks for catching this mistake. I'll fix it this afternoon. I fixed it by changing the JEP. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2118825477
