On Tue, 15 Oct 2024 21:30:13 GMT, Volodymyr Paprotski <d...@openjdk.org> wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix aarch64.ad
>
> src/hotspot/cpu/x86/c2_stubGenerator_x86_64_string.cpp line 414:
>
>> 412: // to the valid haystack bytes on the stack.
>> 413: {
>> 414: const Register haystack = rbx;
>
> Keep `rax` as index for clarity? Although it is really used as a temp..
>
>
> const Register index = rax;
> const Register haystack = rbx;
> copy_to_stack(haystack, haystack_len, false, index , XMM_TMP1, _masm);
I'll use rax as tmp, then.
const Register tmp = rax;
const Register haystack = rbx;
copy_to_stack(haystack, haystack_len, false, tmp , XMM_TMP1, _masm);
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20677#discussion_r1802659159
