On Fri, 11 Oct 2024 06:43:33 GMT, Axel Boldt-Christmas <abold...@openjdk.org> 
wrote:

>> This is the implementation task for `JEP 490: ZGC: Remove the 
>> Non-Generational Mode`. See the JEP for details. 
>> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850)
>
> Axel Boldt-Christmas has updated the pull request with a new target base due 
> to a merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains 12 additional 
> commits since the last revision:
> 
>  - Merge tag 'jdk-24+19' into JDK-8341692
>    
>    Added tag jdk-24+19 for changeset e7c5bf45
>  - LargeWindowPaintTest.java fix id typo
>  - Fix problem-listed @requires typo
>  - Fix @requires !vm.gc.Z, must use vm.gc != "Z"
>  - Reorder z_globals options: product > diagnostic product > develop
>  - Consistent albite special code style
>  - Consistent order between ZArguments and GCArguments
>  - Remove XCollectedHeap from HSDB
>  - Fix typo in TestZUncommitEvent.java
>  - Add missing problem-listing
>  - ... and 2 more: https://git.openjdk.org/jdk/compare/df0ae672...e58b4c5a

The serviceability related changes look good. I suppose the 6 or so SA bugs 
filed against the non-generational ZGC can be closed out. I have a note to 
myself to go through them and close if appropriate. We have 
[JDK-8307393](https://bugs.openjdk.org/browse/JDK-8307393) filed for the lack 
of SA support for generational ZGC, and that is probably the only SA ZGC 
related issue we need to keep around.

-------------

Marked as reviewed by cjplummer (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21401#pullrequestreview-2363665123

Reply via email to