On Sun, 22 Sep 2024 10:09:00 GMT, Thomas Stuefe <[email protected]> wrote:
>> Robert Toyonaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Inherit from ConditionalMutexLocker. Use current_or_null_safe instead of
>> current_or_null.
>
> src/hotspot/share/runtime/mutexLocker.hpp line 261:
>
>> 259: // Same as MutexLocker but can be used during VM init.
>> 260: // Performs no action if given a null mutex or with detached threads.
>> 261: class NMTMutexLocker: public ConditionalMutexLocker {
>
> Good, but either call this something generic (e.g. "SafeMutexLocker") or move
> this to the nmt subdir.
But this isn't generic as it locks the NMT_lock. Maybe move to NMT header file.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20852#discussion_r1770657793
