On Fri, 20 Sep 2024 05:54:11 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> New test is failing on Windows with ZGC: the regex for JAVAHEAP is not >> matching. >> >> Matching "mapped", as well as "private", is testing OK for me: ZGC JAVAHEAP >> is not private in terms of Windows _MEMORY_BASIC_INFORMATION >> >> Simple regex update to a new test which is failing - I'd like to push this >> as a trivial change. > > Hmm, the fix is unnecessarily broad in that it changes the matching to pass > for file mappings for all committed sections. We only use file mappings for > the java heap for ZGC. > > See some lines up, where I solved this for Linux with a separate regex for > the java heap. > > I filed https://bugs.openjdk.org/browse/JDK-8340496 as a follow-up. Thanks @tstuefe I was seeing a lot of test failure notifications, and felt under significant pressure to make them go away, so this was done quickly. Following up with a better solution is great. ------------- PR Comment: https://git.openjdk.org/jdk/pull/21073#issuecomment-2363128493
