On Tue, 13 Aug 2024 16:30:01 GMT, Gerard Ziemski <gziem...@openjdk.org> wrote:
> Is everyone OK with MemTypeFlag? It's quite unfortunate to have a three-word type for something this prolific in our code base. Why not go with `MemType` and change variable names from `flag` to `mt`? static char* map_memory_to_file(size_t size, int fd, MEMFLAGS flag = mtNone); would then become: static char* map_memory_to_file(size_t size, int fd, MemType mt = mtNone); ------------- PR Comment: https://git.openjdk.org/jdk/pull/20497#issuecomment-2287987726