On Tue, 16 Jul 2024 08:52:01 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> src/jdk.jdwp.agent/windows/native/libjdwp/util_md.h line 32: >> >>> 30: #include <stdlib.h> /* for _MAx_PATH */ >>> 31: >>> 32: typedef unsigned long long UNSIGNED_JLONG; >> >> This change has nothing to do with _sprintf. Not sure why it's being made >> here. > > It was a small change, so I thought I could make it out of convenience. I'll > switch it out to a separate changeset There are lots of uses of those type names. If they are going to be cleaned up, I'd prefer that get done as as separate task, so I don't need to think about whether it's okay to do so while in the context of this change. I don't know if __int64 == long long (probably is), but I'm pretty sure I remember seeing a comment on some use of __int32 suggesting it was not the same as what someone expected. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20153#discussion_r1679248371
