On Wed, 1 May 2024 20:45:58 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: tweaks in JVMTI and JDWP changes
>
> src/jdk.jdi/share/classes/com/sun/jdi/ObjectReference.java line 348:
>
>> 346: /**
>> 347: * Returns a List containing a {@link ThreadReference} for
>> 348: * each platform thread currently waiting for this object's monitor.
>
> You need to add "platform" a little below in the `@return` section.
Okay, thanks! Fixed now. The update is:
diff --git a/src/jdk.jdi/share/classes/com/sun/jdi/ObjectReference.java
b/src/jdk.jdi/share/classes/com/sun/jdi/ObjectReference.java
index 3f3490e84cd..affbf9f6c4c 100644
--- a/src/jdk.jdi/share/classes/com/sun/jdi/ObjectReference.java
+++ b/src/jdk.jdi/share/classes/com/sun/jdi/ObjectReference.java
@@ -355,7 +355,8 @@ Value invokeMethod(ThreadReference thread, Method method,
* operation is supported.
*
* @return a List of {@link ThreadReference} objects. The list
- * has zero length if no threads are waiting for the monitor.
+ * has zero length if no threads are waiting for the monitor,
+ * or only virtual threads are waiting for the monitor.
* @throws java.lang.UnsupportedOperationException if the
* target VM does not support this operation.
* @throws IncompatibleThreadStateException if any
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19030#discussion_r1600786965
