On Thu, 2 May 2024 21:14:06 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> src/jdk.jdwp.agent/share/native/libjdwp/util.c line 1289: >> >>> 1287: >>> 1288: static void >>> 1289: verifyMonitorRank(JNIEnv *env, DebugRawMonitorRank rank, jthread >>> thread) >> >> please add a comment that the function should be called under dbgRawMonitor >> lock (also for other functions which assume this) > > ok. I was also thinking of setting a static that contains the jthread of the > thread that holds the lock, and we can assert it is held. Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19044#discussion_r1591678643
