On Wed, 27 Mar 2024 18:31:50 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object
>> information.
>>
>> Not recommended for live production use. Requires UnlockDiagnosticVMOptions
>> and not included in jcmd help output, to remind us this is not a
>> general-purpose customer-facing tool.
>
> Kevin Walls has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Test more pointer types: compiled method and metadata.
test/hotspot/jtreg/serviceability/dcmd/vm/VMInspectTest.java line 117:
> 115: output = executor.execute("VM.inspect -1");
> 116: output.shouldContain("address not safe");
> 117:
Nit: Just a suggestion to make the test more readable. Now when more test cases
have been added you may want to refactor it to call a separate method for each
sub-test.
E.g.: `testBaddAddresses()`, `testMisalignedAddress()`,
`testCompiledMethodAddress()`, `testMetadataAddress()`, `testClassAddress()`,
`testThreadAddress()`, etc.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17655#discussion_r1544038490
