On Sat, 17 Feb 2024 02:41:20 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> The fix updates heap dumpers to report correct instance size value for >> HPROF_GC_CLASS_DUMP records (currently it's reported as size of all instance >> fields) >> >> Testing: tier1, tier2, tier5-svc > > Alex Menkov has updated the pull request incrementally with one additional > commit since the last revision: > > split test src/hotspot/share/services/heapDumper.cpp line 1149: > 1147: DumperClassCacheTableEntry* cache_entry = > class_cache->lookup_or_create(ik); > 1148: > 1149: u4 is = cache_entry->instance_size(); The old version had a check `(cache_entry != nullptr)` at line 1046. Is it not applicable anymore? Can the `cache_entry` be set to `nullptr` at this point? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17855#discussion_r1501339219
