On Mon, 5 Feb 2024 08:52:21 GMT, Suchismith Roy <s...@openjdk.org> wrote:
>> J2SE agent does not start and throws error when it tries to find the shared
>> library ibm_16_am.
>> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
>> fails.It fails to identify the shared library ibm_16_am.a shared archive
>> file on AIX.
>> Hence we are providing a function which will additionally search for .a file
>> on AIX ,when the search for .so file fails.
>
> Suchismith Roy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change logging
The trailing whitespace errors must get fixed (integration blocker).
src/hotspot/os/aix/os_aix.cpp line 1183:
> 1181: // If the load fails,we try to reload by changing the extension to .a
> for .so files only.
> 1182: if (result == nullptr) {
> 1183: if (strcmp(pointer_to_dot, ".so") == 0) {
We could possibly reach here with `pointer_to_dot` == nullptr. Invoking strcmp
causes undefined behavior!
-------------
Changes requested by mdoerr (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16604#pullrequestreview-1862189297
PR Review Comment: https://git.openjdk.org/jdk/pull/16604#discussion_r1477856818
