On Mon, 29 Jan 2024 09:48:40 GMT, Joachim Kern <jk...@openjdk.org> wrote:

>> Suchismith Roy has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   update comment
>
> src/hotspot/os/aix/os_aix.cpp line 1166:
> 
>> 1164:  Search order:
>> 1165:  libfilename-> load "libfilename.so" first,then load libfilename.a,on 
>> failure. 
>> 1166:  In,OpenJ9,the libary with .so extension is loaded first and then .a 
>> extension,on failure.
> 
> Hi Suchi, I'm puzzled. Your comment implies for me, that load library gets a 
> 'base' filename without 'lib' prefix and without extension (e.g. 'name'). 
> Then the j9 code creates the filename 'libname.so' first and on failure 
> 'libname.a' second. What about given libname.so explicitly (e.g. libname.so)? 
> Does j9 really use 'libname.a' as a failure fallback in this case?

The load library gets the entire library name, after construction from 
dll_build_name. This is always a .so file name. When .so file name fails to 
load, we fallback to .a filename. 
Do i need to mention the filename as libfilename.so then ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16604#discussion_r1472417159

Reply via email to