On Sat, 28 Oct 2023 00:45:19 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback > > test/hotspot/jtreg/serviceability/FilteredFields/FilteredFieldsTest.java line > 25: > >> 23: >> 24: /* >> 25: * @test > > @bug and @summary is needed as well. > The test folder has to be at least `test/hotspot/jtreg/serviceability/jvmti`. > It would be nice to check with Leonid on this. Added. Moved test fir to test/hotspot/jtreg/serviceability/jvmti/GetClassFields/ > test/hotspot/jtreg/serviceability/FilteredFields/libFilteredFieldsTest.cpp > line 63: > >> 61: jfieldID *fields = nullptr; >> 62: >> 63: jvmtiError err = jvmti->GetClassFields(clazz, &fcount, &fields); > > Nit: The function `check_jvmti_status()` or `check_jvmti_error()` from > jvmti_common.h` can be used here. > The function `fatal()` in other cases like at line 54 can be used. Fixed ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16328#discussion_r1399969645 PR Review Comment: https://git.openjdk.org/jdk/pull/16328#discussion_r1399970204
