On Thu, 9 Nov 2023 05:27:40 GMT, Jonathan Joo <j...@openjdk.org> wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads > > Jonathan Joo has updated the pull request incrementally with one additional > commit since the last revision: > > Add missing cpuTimeCounters files src/hotspot/share/gc/g1/g1ConcurrentMark.cpp line 2093: > 2091: tttc.do_thread(cm_thread()); > 2092: threads_do(&tttc); > 2093: } Any particular reason for having this in `G1ConcurrentMark` instead of keeping it where it is called in `G1ConcurrentMarkThread`. The implementation would be more or less the same apart from the two last lines: tttc.do_thread(this); cm()->threads_do(&tttc); ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15082#discussion_r1387839879
