On Thu, 7 Sep 2023 01:25:19 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> To test ForceEarlyReturn command for NO_MORE_FRAMES case the test creates >> ThreadStartEventRequest with SUSPEND_ALL policy and requests debuggee to >> start new thread. >> If debuggee JVM starts some internal threads before the request is cleared >> (i.e. we have several ThreadStart events), 2nd event suspends debuggee again >> and the test fails with timeout. >> The change adds THREAD_ONLY modifier to the ThreadStartEventRequest to >> generate event only for desired thread. >> It requires thread ID, so debuggee was updated to create Thread object in >> advance, debugger reads the thread ID from static field (it does not need to >> be static, but Debugee class has convenient methods to retrieve class ID and >> static field value). >> >> Testing: 100 runs of the test on >> windows-x64-debug,linux-x64-debug,macosx-x64-debug with >> JTREG_TEST_THREAD_FACTORY=Virtual, with and without "-XX:+UseZGC >> -XX:+ZGenerational" > > Alex Menkov has updated the pull request incrementally with one additional > commit since the last revision: > > Chris feedback - enhanced comment Ping. need 1 more review. ------------- PR Comment: https://git.openjdk.org/jdk/pull/15601#issuecomment-1719988230