On Thu, 7 Sep 2023 00:56:40 GMT, Alex Menkov <amen...@openjdk.org> wrote:
> The fix looks good to me in general, but I'm not sure about code > organization. src/hotspot/share/runtime/os.hpp describes rules for os* files. > It states: // Platform-independent source files should not include these > header files // (although sadly there are some rare exceptions ...) And the > change adds one more exception. I'd like to hear runtime guys opinion. Thanks for the review, yes, grepping `os_linux.hpp` found several exceptions, I'd like to see if runtime forks have alternatives, too. ------------- PR Comment: https://git.openjdk.org/jdk/pull/15245#issuecomment-1709371785
