On Wed, 19 Jul 2023 09:59:04 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Jean-Philippe Bempel has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. The pull request >> contains one new commit since the last revision: >> >> Revert resolved class to unresolved for comparison >> >> remove is_unresolved_class_mismatch > > src/hotspot/share/oops/constantPool.cpp line 1295: > >> 1293: t1 = JVM_CONSTANT_UnresolvedClass; >> 1294: } >> 1295: > > All consequences of this change are not clear to me yet. > The lines 1307-1314 become not needed anymore. > Also, should the same be done for t2 as well? t2 could be a resolved class, and can be compared with unresolved class because the function klass_name_at() works for both. It might be a good idea to change both of them though, although not necessary imo. You're right 1307-1314 are not reached anymore. Neither is the ClassIndex case but not to remove as part of this change. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14780#discussion_r1276753305
