On Mon, 10 Jul 2023 23:53:03 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
> What testing did you do? Any -Xcomp testing? Just run with -Xcomp on all mach5 platforms, passed > test/hotspot/jtreg/serviceability/jvmti/vthread/GetThreadStateMountedTest/GetThreadStateMountedTest.java > line 41: > >> 39: /** >> 40: * The test implements different scenarios to get desired JVMTI thread >> states. >> 41: * For each scenario test also checks states after carrier and virtual >> threads suspend/resume > > Suggestion: > > * For each scenario the test also checks states after carrier and virtual > threads suspend/resume Fixed > test/hotspot/jtreg/serviceability/jvmti/vthread/GetThreadStateMountedTest/GetThreadStateMountedTest.java > line 45: > >> 43: * Special handling is required for WAITING state scenarios: >> 44: * Spurious wakeups may cause unexpected thread state change and this >> causes test failure. >> 45: * To avoid this test thread should be suspended (i.e. carrier and/or >> mounted virtual thread is suspended). > > Suggestion: > > * To avoid this, the test thread should be suspended (i.e. carrier and/or > mounted virtual thread is suspended). Fixed. ------------- PR Comment: https://git.openjdk.org/jdk/pull/14622#issuecomment-1629939250 PR Review Comment: https://git.openjdk.org/jdk/pull/14622#discussion_r1259052949 PR Review Comment: https://git.openjdk.org/jdk/pull/14622#discussion_r1259053151
