On Fri, 5 May 2023 07:16:12 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Afshin Zafari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8305083: Remove finalize() from test/hotspot/jtreg/vmTestbase/nsk/share/ >> and /jpda that are used in serviceability/dcmd/framework tests > > test/hotspot/jtreg/vmTestbase/nsk/share/Finalizable.java line 44: > >> 42: >> 43: /* >> 44: * This method will register a cleanup method and creates an >> instance of Finalizer > > Nit: `creates` => `create` Done. > test/hotspot/jtreg/vmTestbase/nsk/share/LocalProcess.java line 167: > >> 165: >> 166: /** >> 167: * This method is called at finalization and calls >> <code>kill()</code>. > > Nit: Extra space after `and calls`. Done. > test/hotspot/jtreg/vmTestbase/nsk/share/jpda/BindServer.java line 99: > >> 97: private int busyRequests = 0; >> 98: >> 99: > > Nit: Unneeded extra line. Done. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13420#discussion_r1186184823 PR Review Comment: https://git.openjdk.org/jdk/pull/13420#discussion_r1186184587 PR Review Comment: https://git.openjdk.org/jdk/pull/13420#discussion_r1186184337
