On Tue, 28 Mar 2023 00:53:57 GMT, Dean Long <dl...@openjdk.org> wrote:
>> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Ensure safepoint when processing lock-stack > > src/hotspot/share/interpreter/interpreterRuntime.cpp line 746: > >> 744: ObjectSynchronizer::enter(h_obj, nullptr, current); >> 745: return; >> 746: } > > Why not put this code in a new function declared as > InterpreterRuntime::monitorenter(JavaThread* current, oop obj) and have the > caller decide which one to call? That is a good suggestion, I did that change. Thanks! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/10907#discussion_r1153300881