On Mon, 6 Feb 2023 14:24:51 GMT, Kevin Walls <kev...@openjdk.org> wrote:
> This test fails sometimes with ZGC. It is testing using Panama to access > Windows' last error value, and can of course be interrupted by VM work that > changes the value, but it does generally work. Skipping the test with ZGC is > reasonable as you don't really _have_ to step through this kind of Panama > code with ZGC. > > More rare is a failure where "The application exited" is not observed. This > test is not here to test the exit mode, and logging that failure avoids > telling you whether the correct lastError value was seen. Test should > prioritise saying if the correct last error value was observed, and should > check for the exception being thrown when the correct value is not seen. This pull request has now been integrated. Changeset: c61a3821 Author: Kevin Walls <kev...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/c61a38212e8d7ab8d9ece4c414dddd5032bfd6aa Stats: 8 lines in 1 file changed: 4 ins; 0 del; 4 mod 8296646: com/sun/jdi/JdbLastErrorTest.java test failure Reviewed-by: dholmes, sspitsyn, cjplummer ------------- PR: https://git.openjdk.org/jdk/pull/12441
