On Tue, 10 Jan 2023 16:56:31 GMT, Afshin Zafari <d...@openjdk.org> wrote:

>> test of tier1-5 passed.
>
> Afshin Zafari has updated the pull request incrementally with three 
> additional commits since the last revision:
> 
>  - 8292741: Convert JvmtiTagMapTable to ResourceHashtable
>  - 8292741: Convert JvmtiTagMapTable to ResourceHashtable
>  - 8292741: Convert JvmtiTagMapTable to ResourceHashtable

Changes requested by coleenp (Reviewer).

src/hotspot/share/prims/jvmtiTagMap.cpp line 195:

> 193:   JvmtiTagMap* _tag_map;
> 194:   JvmtiTagMapTable* _hashmap;
> 195:   bool _entry_found;

is this used?

src/hotspot/share/prims/jvmtiTagMapTable.hpp line 44:

> 42: // Its get_hash() and equals() methods are also used for getting the hash
> 43: // value of a Key and comparing two Keys, respectively.
> 44: class JvmtiTagMapKey : public CHeapObj<mtInternal> {

Can you change mtInternal to mtServiceability here?

-------------

PR: https://git.openjdk.org/jdk/pull/11288

Reply via email to