On Tue, 15 Nov 2022 18:52:37 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> The JVM code took a ThreadGroup lock before poking into ThreadGroup fields.
>> Call a method in the ThreadGroup to call the synchronized method instead.
>> Tested with tier 1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Review comments.
I'm sorry for the latency.
Looks good to me.
I've posted one nit though.
Thanks,
Serguei
src/hotspot/share/prims/jvmtiEnvBase.cpp line 564:
> 562:
> 563: for (int i = 0; i < length; i++) {
> 564: objArray[i] =
> (jthreadGroup)JNIHandles::make_local(groups->obj_at(i));
Nit: It is better to use `jni_reference` instead of `JNIHandles::make_local`
for consistency as at the line 549.
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11033
