On Sat, 6 Aug 2022 00:11:08 GMT, Ioi Lam <ik...@openjdk.org> wrote: > To improve modularity and build time, move the declaration of the following > accessor from classfile/javaClasses.hpp to runtime/threadJavaClasses.hpp: > > + java_lang_Thread_FieldHolder > + java_lang_Thread_Constants > + java_lang_ThreadGroup > + java_lang_VirtualThread > > Also move javaThreadStatus.hpp from share/classfile to share/runtime, where > it belongs.
My issue with these kinds of changes in general is that they: - undermine institutional memory - make it harder to do backports due to the shuffling - make it harder to track changes due to the shuffling So the benefit to me has to be more than just a small decrease in some build times which most people are never going to notice anyway. Sorry. Just my 2c. ------------- PR: https://git.openjdk.org/jdk/pull/9788
