On Mon, 7 Jun 2021 08:01:54 GMT, Lin Zang <[email protected]> wrote: >> 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed >> out > > Lin Zang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains 18 additional commits since > the last revision: > > - Merge branch 'master' into sadump-fix > - Merge branch 'master' into sadump-fix > - Merge branch 'master' into s-fix > - add comment for the timestamp value > - Merge branch 'master' into s-fix > - Fix typo and add comment > - Merge branch 'master' into s-fix > - fix typo in comments > - Merge branch 'master' into s-fix > - Merge branch 'master' > - ... and 8 more: > https://git.openjdk.java.net/jdk/compare/1b5ecf20...a87793c3
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java line 1580: > 1578: private boolean allowSegmented; > 1579: // Write data directly to underlying stream. Don't use internal > buffer. > 1580: private boolean unbufferedMode; I would suggest replace `unbufferedMode` with `bufferedMode` field. It will simplify logic a little bit. Then you will need to rename the method `fillSegmentSizeAndEnableUnbufferedMode` to be `fillSegmentSizeAndDisableBufferedMode`. There are several places where `!unbufferedMode` will be replaced with `bufferedMode` . ------------- PR: https://git.openjdk.java.net/jdk/pull/2803
