On Mon, 7 Sep 2020 14:14:28 GMT, Robbin Ehn <[email protected]> wrote:
> When these two methods (set_frame_pop/clear_frame_pop) are called in a > handshake the requesting thread will have lock > the JvmtiThreadState_lock. But the thread executing one of these in the > handshake may not be the owner. > So we only check that JvmtiThreadState_lock is locked. > > When verifying the callers to these methods I notice "clear_to_frame_pop" was > unused, so instead of fixing it I remove > it. > Passes testing locally, still running T3 and T7. > > Now passed! This pull request has now been integrated. Changeset: 704f784c Author: Robbin Ehn <[email protected]> URL: https://git.openjdk.java.net/jdk/commit/704f784c Stats: 26 lines in 4 files changed: 24 ins; 0 del; 2 mod 8252871: fatal error: must own lock JvmtiThreadState_lock 8252816: JvmtiEnvThreadState::clear_to_frame_pop() is not used Reviewed-by: ysuenaga, dholmes ------------- PR: https://git.openjdk.java.net/jdk/pull/60
