ping?
> On Aug 26, 2020, at 4:59 PM, Igor Ignatyev <[email protected]> wrote:
>
> http://cr.openjdk.java.net/~iignatyev//8252402/webrev.00
>> 287 lines changed: 60 ins; 200 del; 27 mod;
>
> Hi all,
>
> could you please review the patch which removes shell script from alloc001
> test?
> there are two small difference comparing to the original test:
> - if we don't get OutOfMemory on mac or windows, the test will be reported as
> skipped (as opposed to passed-passed before)
> - as changing DYLD_LIBRARY_PATH on mac is a bit cumbersome due to SIP, I
> decided to use '-agentpath:' instead of '-agentlib:'
>
> the patch also moves alloc001.java to closer to the other files
> (vmTestbase/nsk/jvmti/Allocate/alloc001), removes TestDescription.java file,
> moves jtreg test description to the test source code and removes printdump
> agent option making trace messages in alloc001.cpp unconditional.
>
> webrev: http://cr.openjdk.java.net/~iignatyev//8252402/webrev.00 (depends on
> 8252401[1,2])
> JBS: https://bugs.openjdk.java.net/browse/JDK-8252402
> testing: vmTestbase/nsk/jvmti/Allocate/alloc001 on {linux,windows,macos}-x64
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8252401
> [2] http://cr.openjdk.java.net/~iignatyev//8252401/webrev.00
>
> Thanks,
> -- Igor
>
