|
Looks good.
Chris
On 8/28/18 1:35 PM, Igor Ignatyev wrote:
JC, Mikael,
thanks for reviewing.
still need a Review from a Reviewer though.
-- Igor
Hi Igor,
Looks good to me,
Jc
Looks good, thanks for fixing!
Cheers,
Mikael
> On Aug 28, 2018, at 11:57 AM, Igor Ignatyev <[email protected]>
wrote:
>
> http://cr.openjdk.java.net/~iignatyev//8210108/webrev.00/index.html
>> 3 lines changed: 1 ins; 1 del; 1 mod;
>
>
> Hi all,
>
> could you please review this small and trivial
follow-up fix?
>
> unfortunately,
test/jdk/sun/tools/jstatd/JstatdTest now uses two
different OutputAnalyzer classes,
jdk.test.lib.process.OutputAnalyzer which it gets from
jdk.test.lib.process.ProcessThread, and
jdk.testlibrary.OutputAnalyzer from
jdk.testlibrary.ProcessTools. as JstatdTest uses
j.t.OutputAnalyzer more often, the fix restores import
statement and uses FQDN where
j.t.l.process.OutputAnalyzer is used.
>
> // we will get rid of this FQDN, as soon as
jdk.testlibrary.ProcessTools is "merged" w/
jdk.t.l.process.ProcessTools, which is tracked by
8210112.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8210108
> webrev: http://cr.openjdk.java.net/~iignatyev//8210108/webrev.00/index.html
> testing: sun/tools/jstatd tests
>
> Thanks,
> -- Igor
--
|
