I've done a little bit more investigation to learn how detach and execute
are expected to work. Looking at the solaris implementation, detach
actually closes
the file descriptor and the check in execute is is fd == -1.
In the macosx implementation the check uses path == null.
So to correct the changeset in progress, I need to restore
the flag indicating that a connection has been made and the
detach case which clears the current connection.
Let me run that through some instrumentation tests cases
and come back with the next webrev tomorrow.
On 12/19/17, 5:46 PM, [email protected] wrote:
More work is needed here. I have not tracked down how detach is
actually used.
The previous path as null string was a flag to reconnect (?).
On 12/19/17 5:23 PM, Chris Plummer wrote:
Hi Gary,
I'm not sure about the detach() and execute() changes on linux (how
can this.path references just be stripped and the code still work
properly), and how does this code continue to work on AIX and MacOSX
when "path" has been removed but is still referenced. Shouldn't
this.path just be replaced with this.socket_name?
thanks,
Chris
