Hi, On Mon, 2013-10-14 at 17:11 +0400, [email protected] wrote: > Hello, Thomas. Did you see this simple diff?
no :) I am not on servicability-dev. Thanks for making me aware of this. > Looks good to me, but I'd like Thomas' opinion as well. > > Thanks, > /Staffan > > On 9 okt 2013, at 00:14, [email protected] wrote: > > > Hello. > > > > I prepared a little fix to JDK-8025925. Find webrev here please: > > http://cr.openjdk.java.net/~iignatyev/atimofeev/8025925/webrev.00/index.html > > (now it's on open server). Staffan Larsen generously agreed to sponsor > > this commit if we conclude everything is OK. Please your provide feedback. I do not think that the issue is fixed by that change; while it compiles and makes it run, it will get the wrong values. In JDK-7163191 I replaced the _regions field with an inlined class. My current patch can be found at http://cr.openjdk.java.net/~tschatzl/8025925/webrev/ I am still testing it - after applying this change the test passes again - but I have never used the SA agent before so I am currently working to find out how to verify that the numbers are okay too :) Thomas
