Thanks Rickard! Can I have another Review, please?
Thanks, /Staffan On 26 jun 2012, at 10:14, Rickard Bäckman wrote: > Looks good. > > /R > > On 06/25/2012 03:49 PM, Staffan Larsen wrote: >> Here is an updated webrev. The last one didn't compile on Solaris. >> >> http://cr.openjdk.java.net/~sla/7178703/webrev.02/ >> >> Thanks, >> /Staffan >> >> On 21 jun 2012, at 13:30, Staffan Larsen wrote: >> >>> Please review the following fix to the diagnostic command framework to >>> improve information and error messages as well as handling of quoted >>> arguments. >>> >>> webrev: http://cr.openjdk.java.net/~sla/7178703/webrev.01/ >>> >>> The bug hasn't been made public yet so here is the description from the bug: >>> ---- >>> Error messages in the dcmd parser can be improved to include information on >>> which argument failed to parse or did not exists. >>> >>> Dcmd parser does not handle quoted arguments correctly (fails to parse >>> them). >>> ---- >>> >>> A new test has been added to verify the handling of quoted arguments. >>> >>> Thanks, >>> /Staffan >> >> >
