Looks like a good compromise to me.

Thanks!
/Staffan

On 10 jun 2012, at 11:28, Alan Bateman wrote:

> 
> sun/tools/jinfo/Basic.java is currently failing with builds of jdk8/tl 
> because SA hasn't been updated to work with the enhanced hashing algorithm 
> for Strings. It probably also needs requires because of the removal of the 
> String offset/count fields. The SA work is tracked by 7175133. In the 
> mean-time we need to add this test to the ProblemList.txt file so that it is 
> excluded from test runs, or else modify the test so that it skips the command 
> line options that use SA. The latter seems preferable so I propose the 
> attached patch. This patch will of course need to be reserved once the SA 
> changes are done.
> 
> -Alan
> 
> diff --git a/test/sun/tools/jinfo/Basic.sh b/test/sun/tools/jinfo/Basic.sh
> --- a/test/sun/tools/jinfo/Basic.sh
> +++ b/test/sun/tools/jinfo/Basic.sh
> @@ -43,7 +43,8 @@ set +e
> 
> failed=0
> 
> -runSA=true
> +# Skip SA options for now, see 7175133
> +runSA=false
> 
> if [ $isMacos = true ]; then
>     runSA=false
> 

Reply via email to