Looks good.
Tiny things:
In globals.hpp, you might take this opportunity to get rid of the
default value for the withComments argument to printFlags.
In diagnosticCommand.hpp, there's a few places with blanks
between parens where the blanks should go away, vis.
static const char* name( ) { ... }
In diagnosticCommand.cpp, in PrintSystemProperties::execute(),
the arguments to call_static don't seem to line up. Possibly a
webrev artifact.
Paul
On 1/5/12 10:19 AM, Frederic Parain wrote:
This changeset aims to add a first set of diagnostic commands
to the HotSpot JVM. It also includes minor modifications to
the diagnostic command framework implementation to ease
development of new diagnostic commands.
The webrev is here:
http://cr.openjdk.java.net/~fparain/7120511/webrev.00/
Here's the list of new diagnostic commands:
Thread.print
Print all threads with stacktraces.
GC.class_histogram
Provides statistics about the Java heap usage
GC.heap_dump
Generate a HPROF format dump of the Java heap
GC.run_finalization
Call java.lang.System.runFinalization().
GC.run
Call java.lang.System.gc().
VM.uptime
Print VM uptime.
VM.flags
Print VM flag options and their current values.
VM.system_properties
Print system properties
VM.command_line
Print the command line used to start this VM instance.
Thanks,
Fred
