Daniel D. Daugherty wrote:
:
I looked at the webrev and it mostly looks okay to me. One issue is
that dbgsysPoll probably should adjust the timeout when interrupted.
Adjust it how? (Just curious)
If the poll is interrupted close to the timeout then it will restart the
poll with the original timeout so it will be longer than it should. For
the debugger transport I don't think this is a big issue as the timeout
is only used in the initial handshake (if I remember correctly). It may
be more trouble that its worth to fix this. As to how then gettimeofday
could be used so that we get the elapsed time of the interrupted poll
and that could be used to adjust the timeout. There are a couple of
example in other places in the JDK.
-Alan
