Kris,
Thanks for the e-mail about the issue. I've filed an Oracle
bug to track the problem:
7050685 4/4 jsdbproc64.sh has a typo in the package name
which should be publicly visible in a day or two via:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7050685
All fixes to HotSpot must go through an internal build and test
tool called JPRT so you typically need to find an Oracle sponsor
for any HotSpot changes.
In this particular case, I'll take care your change and I'll
list "Krystal Mok <[email protected]>" in the "Contributed by:"
line for the changeset.
I'll keep you posted on the progress of your fix. For now, HotSpot
is in a restricted change mode as part of the end-game for JDK7/HSX-21.
Thanks again for finding the bug!
Dan
On 5/4/2011 8:33 AM, Krystal Mok wrote:
Hi all,
There seem to be a typo in Serviceability Agent's JSDB launcher
script, jsdbproc64.sh.
The class name "sun.jvm.hotspot.tools.soql.JSDB" is incorrectly
written as "sun.jvm.hotspot.tools.JSDB" in this script.
This script also contains a few extra Carriage Return characters at
the end of lines, which should be removed.
This is found in jdk7/jdk7/hotspot and hsx20/baseline, and in earlier
releases as well.
The 32-bit counterpart, jsdbproc.sh doesn't have these problems, nor
do the Windows versions, jsdbwindbg(64).bat.
The fix would be: (based on hsx20/baseline)
$ hg diff
diff -r f0f676c5a2c6 agent/make/jsdbproc64.sh
--- a/agent/make/jsdbproc64.sh Tue Mar 15 19:30:16 2011 -0700
+++ b/agent/make/jsdbproc64.sh Wed May 04 22:25:52 2011 +0800
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/sh
#
# Copyright (c) 2004, Oracle and/or its affiliates. All rights reserved.
@@ -24,7 +24,7 @@
#
#
-
-. `dirname $0`/saenv64.sh
-
-$SA_JAVA_CMD sun.jvm.hotspot.tools.JSDB $*
+
+. `dirname $0`/saenv64.sh
+
+$SA_JAVA_CMD sun.jvm.hotspot.tools.soql.JSDB $*
P.S. Are there any simple-to-follow guides on how one can make small
contributions to this kind of code?
Regards,
Kris Mok
