On 5/16/2011 1:48 PM, Mandy Chung wrote:
On 05/16/11 12:33, Daniel D. Daugherty wrote:
Would this fix 7016208? It seems to me that addLogger returning
boolean
is the cause for this bug.
Yes it probably would fix 7016208, but I would prefer to go
with what I have. Yes, addLogger() returning a boolean was
a bad design choice way back when.
We'll have to look at tweaking the Logging API in JDK8.
Are you okay if I go with what I have (modulo a few editorial
changes)?
Given the amount of testing it takes to verify these fixes, I'm fine with
pushing your version to JDK 7. Can you put a comment to describe
this proposed alternative solution so that someone may revise this
fix in JDK 8 when working on LogManager code?
I'm filing a new bug for JDK8 that describes the results
of my lock analysis and other issues that I found when I
crawled through the code. I will include your suggestion
in that bug. You'll be on the interest list...
Thanks for the review!
Dan
