Nils Loodin wrote:
Hello all!
My name is Nils Loodin ,and I work in the swedish SQE team, now under
Ken chen. I've been working on the refresh demos project (PRD req. no.
537450)
I actually sent a request for a review previously, but that mail seems to have gone missing (thanks Beehive), but it's available at the mailing list archive:
(http://mail.openjdk.java.net/pipermail/serviceability-dev/2011-April/003868.html)
Anyway, that might be for the better, since I've had time to update the webrev
with some more stuff after comments from the nice Mandy Chung!
One thing to note though, is that this was a pretty time bound project, but
with a lot of code to go through and update. There are definitely things to do,
still. perhaps this can be reviewed as an initial effort.
(Overview here:
https://sunspace.sfbay.sun.com/display/JAVASE/JDK+7+Demos+Update)
The changes should be pretty trivial. Mostly added annotations, using
for-each constructs and generics instead of raw types.
Please have a look here:
http://wikifiles.se.oracle.com/qa/nloodin/7029383/webrev.01/
<http://wikifiles.se.oracle.com/qa/nloodin/7029383/webrev.00/>
Regards
Nils Loodin
Nils - I don't think these links are accessible outside of Oracle's
network so it would be good to make the webrev available on a internet
facing http server (like cr.openjdk.java.net) so that folks can see the
changes.
One initial comment is that the changes to the
com/sun/tools/example/debug/{bdi,gui} make me wonder if it might be time
to just get rid of the old javadt demo. Robert or Jim might have
opinions on this but I think it's been gathering dust for many years. It
was clearly useful when JPDA was created but not clear to me that it's
worth keeping now. We need to keep jdb of course. Another thing I notice
is that it looks to me the sources for this demo end up in both
examples.jar and src.zip. I don't think src.zip existed in prior JDK
releases so this might be a recent problem.
-Alan
