Re: request for review: 6436034: Instance filter doesn't filter event if it occurs in native method

Fri, 17 Dec 2010 10:50:32 -0800

On 12/17/2010 11:35 AM, Keith McGuigan wrote:

On Dec 16, 2010, at 7:18 PM, Mandy Chung wrote:

 It's more of the maintainence cost and readability (supporting the latest version vs all existing versions 1.1 and up) that I'd like to give my feedback so that you (new owner) can make the right judgement call :)

I don't claim to own any of this! :)    As far as I'm concerned, Dan is the owner!

Yup. The buck currently stops with me. Sorry for not getting
back to this e-mail thread sooner. I was in deep on the SA
problem with Windows VS2010.

I just posted on the previous review request.

Yes, you can use internal API in jtreg test.  You need to add a special javac flag to the test:
    @compile -XDignore.symbol.file <classname>

You can reference jdk/test/sun/misc/Version/Version.java.

Thanks, Mandy - this is much cleaner: 

I definitely like the latest version of the test.

Dan

Reply via email to